Enable interleaved sliding_window for gemma3 #1344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiminha
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz-intel,
vivekgoe,
afierka-intel,
xuechendi,
jikunshang and
mswiniarsk
as code owners
jiminha
changed the title
ssarkar2
force-pushed
the
jha/sliding_window_gemma3
branch
from
aa86d92 to
a9e5a7d
Compare
ssarkar2
force-pushed
the
jha/sliding_window_gemma3
branch
from
1d44a03 to
f783955
Compare
ssarkar2
force-pushed
the
jha/sliding_window_gemma3
branch
from
716e329 to
be41114
Compare
jiminha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable interleaved sliding_window for gemma3
Without this change, prompts longer than size of sliding_window have an accuracy issue.